spKillSessionsForShardMappingLocal: Fix deadlock when the session is already gone #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I see that this project is alive again. Do you plan to merge this PR? Or somehow fix the problem? |
|
I don't have any context into this PR, and I don't see any tests for it (or even how to manually test the PR). Can anyone describe how to test this PR? Is it covered by an existing test? (I am not keen on merging PRs with no tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed deadlock when the kill always returns 6106 forever for the session that is already gone. In this modification it will try to kill the session only once then moving to next in the next round.
Not sure I modified script versioning correctly, but you can see the idea of the fix.
This also probably address some issues mentioned in #166.